[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: library rebuilt after "make check"

From: Ralf Wildenhues
Subject: Re: library rebuilt after "make check"
Date: Sat, 19 Sep 2009 09:29:44 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

* Vincent Lefevre wrote on Fri, Sep 18, 2009 at 11:19:35PM CEST:
> On 2009-09-18 19:15:12 +0200, Ralf Wildenhues wrote:
> > What system and file system is this on, which make implementation and
> > version, which autoconf version, do you use the parallel-tests option,
> > and when will mpfr.org be online again?
> Mac OS X (PowerPC) 10.4.11, HFS+, GNU Make 3.80, GNU Autoconf 2.64,
> GNU libtool 2.2.6, make -j2.
> mpfr.org should be back online on Saturday at 18:00 UTC.
> https://gforge.inria.fr/projects/mpfr/ is hosted somewhere else,
> thus is accessible.

Thanks.  Please fix the wording on
<https://gforge.inria.fr/scm/?group_id=136> to state that, for checking
out the project source code repo, one only needs .../svn/mpfr/trunk, and
not the command listed which also checks out www pages, old tarballs,
branches, tags, and all.

Notes to the sources:

Please use the patch below to also let non-GNU make see the dependency
on the libmpfr.la file of the programs (so they are relinked if the
library is updated).  Non-GNU make don't identify ./FILE with FILE.

What is LOADLIBES in tests/Makefile.am used for?

Please line-wrap libmpfr_la_SOURCES, you're over 2K already which is the
limit for some vendor grep that then cut silently (the build system
might use grep on Makefile.am).  I don't think Darwin is in the boat
with this issue, it's definitely not on the 8.11.0 I've just tried.

The tests patch below should avoid a harmless warning when using
parallel make.

BTW, do you still have a complete log of the first 'make'?  Was
set_flt.lo even compiled at all the first time?  Was automake rerun at
that time?  Is this a reproducible issue?

Hope that helps.  If the problem persists, please ensure
.deps/set_flt.Plo exists, is filled correctly by the compiler the first
time it is compiled, and is included in the Makefile.  Other than that,
I'd probably want to see the system this is happening on.


        * Makefile.am: Use libmpfr.la not $(top_builddir)/libmpfr.la.
        * tests/Makefile.am: Use $(MAKE) $(AM_MAKEFLAGS) not 'make'.

Index: Makefile.am
--- Makefile.am (Revision 6475)
+++ Makefile.am (Arbeitskopie)
@@ -68,11 +68,11 @@
 EXTRA_PROGRAMS = tuneup speed
 tuneup_SOURCES = tuneup.c
-tuneup_LDADD = -lspeed $(top_builddir)/libmpfr.la
+tuneup_LDADD = -lspeed libmpfr.la
 tuneup_LDFLAGS = -static
 speed_SOURCES = speed.c
-speed_LDADD = -lspeed $(top_builddir)/libmpfr.la
+speed_LDADD = -lspeed libmpfr.la
 speed_LDFLAGS = -static
Index: tests/Makefile.am
--- tests/Makefile.am   (Revision 6475)
+++ tests/Makefile.am   (Arbeitskopie)
@@ -45,7 +45,7 @@
 libfrtests_la_SOURCES = mpfr-test.h memory.c rnd_mode.c tests.c cmp_str.c 
-       cd $(top_builddir); make libmpfr.la
+       cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) libmpfr.la
 TESTS = $(check_PROGRAMS)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]