[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#8969: improve synchronization between examples in the manual and tes
bug#8969: improve synchronization between examples in the manual and test cases
Fri, 8 Jul 2011 09:58:58 +0200
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )
On Wednesday 06 July 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Jul 06, 2011 at 10:32:56AM CEST:
> > Oops, sorry. Fixed by the attached patch. OK for maint? I'll wait
> > the customary 72 hours before pushing.
> Thanks. OK, but please remove all the comments about tar unportability
> in the tests. It's so obvious. ;-)
> (and there are probably a dozen other places in the Automake source tree
> that you'd have to put the comment at as well, for any amount of
> consistency. I think having one comment, the one that already exists in
> lib/am/distdir.am, is fully sufficient.)
> > > I'm ok with fixing the manual also, although it's
> > > usually clear for people still having to use those vendor tars (and
> > > inconvenient for the rest).
> > >
> > Yes, I'd say we leave the examples in manual untouched. Agreed?
> > Subject: [PATCH] tests: portability fixes in tests on amhello examples
> > * tests/amhello-binpkg.test: Don't use "tar xzf too.tag.gz" to
> > extract a gzip-compressed tarball, that's unportable to some
> > tar implementations; use the "gzip -dc fo.tar.gz | tar xf -"
> > idiom instead.
> > * tests/amhello-cflags.test: Likewise.
> > * tests/amhello-cross-compile.test: Likewise.