bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bash40-011 patch can't be applied cleanly


From: Sergei Steshenko
Subject: Re: bash40-011 patch can't be applied cleanly
Date: Thu, 19 Nov 2009 07:47:48 -0800 (PST)


--- On Thu, 11/19/09, Greg Wooledge <address@hidden> wrote:

> From: Greg Wooledge <address@hidden>
> Subject: Re: bash40-011 patch can't be applied cleanly
> To: "Sergei Steshenko" <address@hidden>
> Cc: address@hidden
> Date: Thursday, November 19, 2009, 5:05 AM
> On Wed, Nov 18, 2009 at 06:54:01PM
> -0800, Sergei Steshenko wrote:
> > My script was applying patches from 'bash-4.0-patches'
> directory, not from
> > 'bash-4.0' one, and maybe this was my mistake.
> 
> Yes.  You should always be in the source directory
> you're patching,
> when you apply a patch.  The only question is whether
> you need to use
> patch -p0 or patch -p1.  And the only way you'll know
> that is by reading
> the patch itself.
> 
> In the case of Chet's bash patches, it's always -p0.
> 
> (I'm saying this mostly for anyone reading the archives,
> since this is
> a common point of confusion.)
> 

No, there shouldn't be

"
And the only way you'll know that is by reading the patch itself.
",

there shouldn't be any need in human intervention, there should be a
convention followed by participants of a given project.

There is no need to waste time on routine tasks. And, if you wish, there
shouldn't be "bazaar" in this case.

Actually, my script applies patches to some other targets, it's still 
'-p0'.

...

Thanks for the clarification regarding the directory.

Regards,
  Sergei.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]