Re: [patch] fix building when readline is disabled

[Mike Frysinger]

On Monday 23 April 2012 18:57:05 Chet Ramey wrote:
> On 4/23/12 12:22 AM, Mike Frysinger wrote:
> > if you disable readline, the complete.def code fails to build.  simple
> > patch below (not sure if it's correct, but at least gets the
> > conversation going).
> 
> How did you disable readline?  Running configure --disable-readline and
> building as usual works for me.  You might want to run `make clean' before
> rebuilding.

i suspect you have readline files still being included and it appears to work.

let's look at vanilla bash-4.2:
$ tar xf bash-4.2.tar.gz
$ cd bash-4.2
$ ./configure --disable-readline
$ make
...
rm -f complete.o
./mkbuiltins -D . complete.def
gcc -c  -DHAVE_CONFIG_H -DSHELL  -I. -I..  -I.. -I../include -I../lib -I.    -g 
-O2 complete.c || ( rm -f complete.c ; exit 1 )
rm -f complete.c
...

so, let's go into that dir and run it by hand:
$ cd builtins
$ ./mkbuiltins -D . complete.def
$ strace -f -eopen gcc -c  -DHAVE_CONFIG_H -DSHELL  -I. -I..  -I.. -I../include 
-I../lib -I.    -g -O2 complete.c |& grep readline.h
...
[pid 12453] open("../lib/readline/readline.h", O_RDONLY|O_NOCTTY) = 4
...

if you were to clean out your readline code first, you'd see the build error
i'm seeing instead of the local readline code getting implicitly used even
though it was explicitly disabled.
-mike

signature.asc
Description: This is a digitally signed message part.