[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling

From: Nick Clifton
Subject: Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling
Date: Wed, 23 Mar 2005 15:07:16 +0000
User-agent: Mozilla Thunderbird 1.0 (X11/20041206)

Hi Vladimirm,

Attached patch fix warning.


I don't known is proposed patch correct.
But I check FreeBSD CVS and found that starting from 1994 FreeBSD have getopt prototype same as in binutils getopt.h.

Well that should be long enough. I think that the patch is OK, but there are two problems:

1. The patch should be submitted to the gcc project, since they control the getopt.h header file.

   2. You need to include a ChangeLog entry with your patch.

Also, I am not sure if the FreeBSD system uses the GNU C library. I guess that it probably does, but if not then you ought to update the comment describing when the full getopt() prototype is used.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]