[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-de
From: |
Brian dot Ford at FlightSafety dot com |
Subject: |
[Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink" |
Date: |
24 Jan 2006 18:42:22 -0000 |
------- Additional Comments From Brian dot Ford at FlightSafety dot com
2006-01-24 18:42 -------
(In reply to comment #9)
> binutils/ChangeLog
> 2006-01-18 Nick Clifton <address@hidden>
>
> PR binutils/1391
> * objcopy.c (copy_object): For PE format targets set the VMA of a
> newly created gnu_debuglink section to a non-zero, aligned,
> contiguous value.
> * Makefile.am (objcopy.c): Add a dependency upon libbfd.h.
> * Makefile.in: Regenerate.
Sorry. I was waiting to reply until I had a chance to test it, and time has
been in short supply lately. Two questions though:
Pedantically, doesn't this patch belong in bfd/opncls.c
(bfd_create_gnu_debuglink_section)? I imagine objcopy is currently the only
user of that function, but it seems to me like it is the wrong place for the
fix.
Although hackish, there is precedent in bfd/bfd.c (bfd_get_sign_extend_vma) to
use name = bfd_get_target (abfd); if (strcmp (name, "pei-i386") == 0) as the
test for a PE image.
Thanks for taking the time to look at it.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1391
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", Brian dot Ford at FlightSafety dot com, 2006/01/12
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", nickc at redhat dot com, 2006/01/16
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", nickc at redhat dot com, 2006/01/16
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", dannysmith at users dot sourceforge dot net, 2006/01/17
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", nickc at redhat dot com, 2006/01/18
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink",
Brian dot Ford at FlightSafety dot com <=
- [Bug binutils/1391] objcopy trashes PE executable when using "add-gnu-debuglink", nickc at redhat dot com, 2006/01/26