Re: as: multiple definitions is now error

[Nick Clifton]

Hi Fabian,

> as.exe --defsym PPC603=1 ...
>
> file:
> .set PPC603, 1  # or PPC603 = 1

> file:32: Error: symbol `PPC603' is already defined

> The docs states:
>
> "You may .set a symbol many times in the same assembly."
> http://sourceware.org/binutils/docs-2.17/as/Set.html#Set

Although the docs never promise that --defsym will behave in the same 
way as .set.

> So know is that a bug?

Not a bug as such, more of a mis-feature.  Please could you try out the 
attached patch which I think will resolve the problem for you.

Cheers
  Nick


Index: gas/as.c
===================================================================
RCS file: /cvs/src/src/gas/as.c,v
retrieving revision 1.69
diff -c -3 -p -r1.69 as.c
*** gas/as.c    7 Jun 2006 11:27:57 -0000       1.69
--- gas/as.c    24 Jan 2007 14:35:52 -0000
*************** main (int argc, char ** argv)
*** 1122,1127 ****
--- 1122,1128 ----
  
        sym = symbol_new (defsyms->name, absolute_section, defsyms->value,
                        &zero_address_frag);
+       S_SET_VOLATILE (sym);
        symbol_table_insert (sym);
        next = defsyms->next;
        free (defsyms);