[Bug gas/11395] gas creates 64bit add-instruction in 32bit mode for hppa2.0

[nickc at redhat dot com]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2010-04-16 
11:21 -------
Subject: Bug 11395

CVSROOT:        /cvs/src
Module name:    src
Changes by:     address@hidden  2010-04-16 11:20:41

Modified files:
        gas            : ChangeLog 
        gas/config     : tc-hppa.c 
        gas/testsuite  : ChangeLog 
        gas/testsuite/gas/hppa/basic: add2.s basic.exp 

Log message:
        PR gas/11395
        * config/tc-hppa.c (pa_ip): Do not allow 64-bit add condition
        matcher to accept and unconditional 32-bit add instruction.
        (pa_build_unwind_subspace): Cope with error conditions not
        allowing the start symbol to be set.
        
        * gas/hppa/basic/add2.s: Add test of simple 32-bit instruction.
        * gas/hppa/basic/basic.exp (do_add2): Add grep for expected
        disassembly.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/ChangeLog.diff?cvsroot=src&r1=1.4131&r2=1.4132
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-hppa.c.diff?cvsroot=src&r1=1.147&r2=1.148
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1655&r2=1.1656
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/hppa/basic/add2.s.diff?cvsroot=src&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/hppa/basic/basic.exp.diff?cvsroot=src&r1=1.13&r2=1.14


------- Additional Comments From nickc at redhat dot com  2010-04-16 11:23 
-------
Hi Michael,

  Sorry for taking so long to look at this problem.

  It turns out to be a bug in GAS's code for parsing condition prefixes for
64-bit addition instructions.  If there were no conditions at all the
instruction was being matched and treated as a 64-bit add, instead of being
rejected and allowing the parser to proceed to the 32-bit add pattern.

  I have checked in a patch to fix this, as well as an addition to the HPPA part
of the GAS testsuite to make sure that the bug stays fixed.

Cheers
  Nick


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11395

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.