[Bug binutils/13421] readelf -u generates output for relocatable ARM objects

[dave.martin at linaro dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13421

--- Comment #3 from Dave Martin <dave.martin at linaro dot org> 2011-11-25 
18:32:39 UTC ---
On Fri, Nov 25, 2011 at 02:16:56PM +0000, nickc at redhat dot com wrote:
> http://sourceware.org/bugzilla/show_bug.cgi?id=13421
> 
> Nick Clifton <nickc at redhat dot com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |WAITING
>                  CC|                            |nickc at redhat dot com
> 
> --- Comment #2 from Nick Clifton <nickc at redhat dot com> 2011-11-25 
> 14:16:56 UTC ---
> Hi Dave,
> 
> > Instead, a {section,address} pair should be generated by
> > applying the relocation addend to the target symbol's 
> > {section,address} pair, with the resultant pair used 
> > for locating the unwind opcodes and function symbol.
> 
> Actually this is being done already - it is just that the code that did this
> was broken...
> 
> Please try out the uploaded patch and let me know what you think.
> 
> The patch includes a lot of formatting and coding tidy-ups, (although not the
> full code refactoring that you suggested), so it may be hard to find the real
> changes.  The fixes are as follows:
> 
>   1. Correctly initialize the rel_type field in the arm_section structure.
> 
>   2. When displaying the function name, use the computed function
> section/offset abdaddr structure, not the entry absaddr structure.

I guess I don't have a strong opinion on the code -- the fix appears to
work, so I'm happy.

Thanks for the quick response!

Cheers
---Dave

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.