[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/14243] software that includes bfd.h fails to build with "#

From: maynardj at us dot ibm.com
Subject: [Bug binutils/14243] software that includes bfd.h fails to build with "#error config.h must be included before this header"
Date: Fri, 15 Jun 2012 15:15:56 +0000


--- Comment #4 from Maynard Johnson <maynardj at us dot ibm.com> 2012-06-15 
15:15:56 UTC ---
(In reply to comment #2)
> A further comment.  I see HAVE_STRINGIZE is obsolescent according to the
> autoconf docs.  So my argument for config.h being included before the current
> version of bfd.h isn't really that strong.  However, it is a really good idea
> to always include config.h (or sysdep.h or alloca-conf.h that include 
> config.h)
> before any other files, including system headers.  See bug #13558.
> Beside all that, I can't see the binutils project reverting this change.  Yes,
> it causes some initial pain (and I grumbled about the change myself), but
> overall the change is a good one.  If you (oprofile project) want to insulate
> yourself from a change like this one, then you really should be distributing
> your own copy of bfd along with oprofile sources.  That would allow you to
> resolve these issues at your leisure.

OK, I'll post patches to the oprofile list to comply with this requirement. 
You can close this bug report. Thanks.

Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]