[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/17321] add --enable-reloc-section option to generate proper relo

From: nickc at redhat dot com
Subject: [Bug ld/17321] add --enable-reloc-section option to generate proper relocation sections to .exes
Date: Wed, 17 Sep 2014 15:05:30 +0000


Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
                 CC|                            |nickc at redhat dot com

--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
Hi Eriin,

  The patch is basically OK, ie acceptable, apart from a couple of small

  1.  The changes to ld/emultempl/pep.em should refer to a variable called
pep_dll_enable_reloc_section rather than pe_dll_enable_reloc_section, and this
variable should be prototyped in ld/pep-dll.h and #define-d in ld/pep-dll.c.

      Try building a toolchain configure for an "x86_64-pc-cygwin" target to
see why this is necessary.

  2.  The patch should include an update to ld/ld.texinfo describing the new
command line option and when it should be used.

  3.  The patch needs a changelog entry, citing the author.  You also need to
make sure that the author has granted permission for this patch to be included
in the binutils sources and he/she/it has assigned the copyright for the patch
over to the FSF.

With these changes I would be happy to accept the patches into the sources.


You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]