[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug binutils/18750] Stack buffer overflow when printing bad bytes in In
From: |
tyhicks at canonical dot com |
Subject: |
[Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects |
Date: |
Fri, 31 Jul 2015 20:37:20 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=18750
--- Comment #5 from Tyler Hicks <tyhicks at canonical dot com> ---
Yes, but srec.c gets it right by storing the bytes in an unsigned char instead
of a signed one. I now think that ihex.c should also have this change, as well:
diff --git a/bfd/ihex.c b/bfd/ihex.c
index 8e66372..31d1cc7 100644
--- a/bfd/ihex.c
+++ b/bfd/ihex.c
@@ -276,7 +276,7 @@ ihex_scan (bfd *abfd)
else
{
file_ptr pos;
- char hdr[8];
+ unsigned char hdr[8];
unsigned int i;
unsigned int len;
bfd_vma addr;
--
You are receiving this mail because:
You are on the CC list for the bug.
- [Bug binutils/18750] New: Stack buffer overflow when printing bad bytes in Intel Hex objects, tyhicks at canonical dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, tyhicks at canonical dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, tyhicks at canonical dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, yumkam+binutils at gmail dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, yumkam+binutils at gmail dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects,
tyhicks at canonical dot com <=
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, yumkam+binutils at gmail dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, tyhicks at canonical dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, yumkam+binutils at gmail dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, tyhicks at canonical dot com, 2015/07/31
- [Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects, yumkam+binutils at gmail dot com, 2015/07/31