[Bug gold/19842] LTO build fails to write call address for weak symbol reference

[ccoutant at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19842

--- Comment #19 from Cary Coutant <ccoutant at gmail dot com> ---
> commit 3a5dbfb2502e7a49422f13c9cec2becfd46f44f1
> Author: Alan Modra <address@hidden>
> Date:   Tue Jun 21 14:55:26 2011 +0000
>
>       * elflink.c (_bfd_elf_merge_symbol): Allow type changes for
>       plugin symbols.  Fix segfault on linker scrip defined syms.
>
> has
>
>   /* Skip weak definitions of symbols that are already defined.  */
>   if (newdef && olddef && newweak)
>     {
>       /* Don't skip new non-IR weak syms.  */
>       if (!(oldbfd != NULL
>             && (oldbfd->flags & BFD_PLUGIN) != 0
>             && (abfd->flags & BFD_PLUGIN) == 0))
>         {
>           newdef = FALSE;
>           *skip = TRUE;
>         }

I don't think this patch is relevant. In the lines you quoted, the
only change introduced by Alan's patch was to check for oldbfd !=
NULL.

-cary

-- 
You are receiving this mail because:
You are on the CC list for the bug.