[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gold/22770] [MIPS] GOLD fails to link ghc: internal error in get_go

From: cvs-commit at gcc dot gnu.org
Subject: [Bug gold/22770] [MIPS] GOLD fails to link ghc: internal error in get_got_page_offset, at gold/mips.cc:6271
Date: Thu, 05 Apr 2018 15:49:12 +0000


--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Cary Coutant <address@hidden>:


commit 67faf1f4c206516837fa44f6b7d131966be6bf0f
Author: James Cowgill <address@hidden>
Date:   Thu Apr 5 08:47:53 2018 -0700

    MIPS: Fix GOT page counter in multi-got links

    The record_got_page_entry function records and updates the maximum
    number of GOT page entries which may be required by an object. In the
    case where an existing GOT page entry was expanded, only the entry
    belonging to output GOT would have its page count updated. This leaves
    the entry belonging to the object GOT with the num_pages count of 1 it
    was originally initialized with. Later on when GOTs are being merged in a
    multi-got link, this causes the value of entry->num_pages in
    add_got_page_entries to always be 1 and underestimates the number of pages
    required for the new entry. This in turn leads to an assertion failure in
    get_got_page_offset where we run out of pages.

    Fix by obtaining the object's GOT entry unconditionally and not just
    the first time it gets created. Now that entry2 is always valid, remove
    the useless NULL checks.

        PR gold/22770
        * mips.cc (Mips_got_info::record_got_page_entry): Fetch existing
        page entries for the object's GOT.

You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]