[Bug swing/24651] JMenu layout problem with nested menus

[roman at kennke dot org]

------- Comment #19 from roman at kennke dot org  2005-11-09 08:40 -------
Subject: Re:  JMenu layout problem with nested menus

Hi Norman,

Am Dienstag, den 08.11.2005, 20:03 +0100 schrieb Norman Hendrich:
> Hello Roman, hello Lillian,
> 
> my personal breaking point is reached now... I'll stop testing cvs
> for a while. (I have a few Robot-based tests lying around, but they
> are useless while classpath reports wrong window positions. I can
> submit them later.)

Sorry to disturb you, but this is the nature of rapid development, the
latest CVS may be broken or have regressions. These are normally fixed
in the next release.

> > I fixed this in the morning.
> 
> Well, but your fix seems to incur a *MAJOR* performance regression.

If you see performance regressions, this may be due to my
Component.invalidate() change. I reverted this yesterday. Make sure you
have the reverting commit.

> ... unless showing the menu involves an invalidate() somehow,

it does. And my invalidate() patch has made the invalidate() very
inefficient.

> This makes about ten bug reports with testcases, for menu and
> popup menu alone, and the result is worse than in 0.18. Any ideas?

You don't need to file every little thing as bugreport with testcases if
you don't feel like it. Sometimes a small report about problems helps
(like this one), sometimes we need a testcase and then we will say so.
For now it would be good to know if you already had the invalidate()
reverting patch from yesterday applied and still have performance
problems.

Greetings,
Roman


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24651