Re: [ cplusplus-Bugs-594627 ] XMLRPC constructor bug ?

[Federico Montesino Pouzols]

   Your patches have been applied and the unused old strtreams
have been removed. The changes are in the cvs hosted at
savannah. Thanks a lot!

   I have tested XMLRPC with a simple demo (printing to stdout)
and have found that the old buggy constructor gave a SIGSEGV.
Your new version seems to work ok.

   By the way, is there any sample on using XMLRPC? If not, I
would tidy a bit my test and add it to the demo set.


>
> Subject: [ cplusplus-Bugs-594627 ] XMLRPC constructor bug ?
> Date: Tue, 13 Aug 2002 08:00:47 -0700
> From: address@hidden
> To: address@hidden
>
> Bugs item #594627, was opened at 2002-08-13 17:00
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=101523&aid=594627&group_id1523
>
> Category: Bug Reporter
> Group: None
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Norbert Koch (nkoch)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: XMLRPC constructor bug ?
>
> Initial Comment:
> Hello.
>
> I found this in xml.cpp:
>
> XMLRPC::XMLRPC(size_t bs) :
> XMLStream()
> {
>         buffer = new char[bufsize];
>         strbuf = NULL;
>         bufsize = bs;
> }
>
> Shouldn't it be:
>  buffer = new char[bs]
>  ...
>  bufsize = bs
> ?
>
> By the way:
> When compiling my app with
> gcc3.1.1 I get warnings
> about (deprecated) <strstream> inclusion
> in some header files.
>
> I suggest removing #include <strstream>
> from slog.h and digest.h as I don't see
> it being used anywhere.
>
> I suggest to replace <strstream> by
> <sstream> in xml.h and using sdt::stringstream
> in xml.cpp which simplifies things.
> See enclosed patch files for xml.cpp and xml.h.
> (It compiles but I did not yet test if it runs)
>
> ----------------------------------------------------------------------
>
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=101523&aid=594627&group_id1523
>
> -------------------------------------------------------