Re: Patch for bug's in SocketPort and IOException

[Federico Montesino Pouzols]

On Wed, Nov 20, 2002 at 12:30:37PM +0100, Prochnow, Christian wrote:
> Hi List,
> 
> found some problems in recently added features:
> 

        Ok, fixed.

> in IOException::getSystemErrorString():
> - _systemErrorString must only be allocated once.
> 
> - i thought "if ( NULL == _systemErrorString )" was not the intention of the 
> programmer, instead it should be "if ( NULL != _systemErrorString )"
> 

        Umm, yes, I do not know why I put the if before the
FormatMessage instead of the new.

> - in IOException::~IOException():
> delete _systemErrorString - simply not right - array`s are deleted with
> delete[] not with delete.
> 
> SocketPort connecting constructor:
> - do not restore the O_NDLAY flag when ::connect() has failed!
>  this caused the connectError() to store a zero error code cause the fcntl() 
> after connect() succeeded :)
> 

        I have applied the patch section for this to both HEAD and
RELEASE1.

> Regards,
> Christian
> 
> -- 
> Christian Prochnow
> Berliner Freiverkehr (Aktien) AG - Kurfürstendamm 117 - 10711 Berlin, Germany
> Fon: +49-30-89606409, Fax: +49-30-89021389 - EMail: address@hidden