[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compiler warnings; minor thread.h patch
From: |
Federico Montesino Pouzols |
Subject: |
Re: Compiler warnings; minor thread.h patch |
Date: |
Sun, 29 Dec 2002 14:52:39 +0100 |
User-agent: |
Mutt/1.4i |
On Sun, Dec 29, 2002 at 01:15:26PM +0200, Albert Strasheim wrote:
> Hello,
>
> Attached is a patch to remove the extra qualification of getThreadID()
> in thread.h on line 1352.
>
Fixed in CVS.
> This warning shows up when compiling Common C++ with the -Wall, -ansi,
> and -pedantic flags. I think this should be made the default for the
> project?
>
Yes, it has been suggested by other people on this list and I
think it should be done -if is no objection- for the next release. It
would require adding a conditional check for gcc -and fixing a lot of
seemingly inoffensive warnings that show up when these options are
specified.
> Another interesting issue that shows up is the extensive use of long
> long constants in sha.cpp, which is apparently forbidden by ANSI C++.
>
> Cheers,
>
> Albert
- Compiler warnings; minor thread.h patch, Albert Strasheim, 2002/12/29
- Re: Compiler warnings; minor thread.h patch,
Federico Montesino Pouzols <=
- Re: Compiler warnings; minor thread.h patch, David Sugar, 2002/12/29
- Re: Compiler warnings; minor thread.h patch, Albert Strasheim, 2002/12/29
- Re: Compiler warnings; minor thread.h patch, Albert Strasheim, 2002/12/30
- Re: Compiler warnings; minor thread.h patch, Federico Montesino Pouzols, 2002/12/30
- Re: Compiler warnings; minor thread.h patch, David Sugar, 2002/12/30
- Re: Compiler warnings; minor thread.h patch, Albert Strasheim, 2002/12/30
- Re: Compiler warnings; minor thread.h patch, Federico Montesino Pouzols, 2002/12/30