bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-4.5.12 build feedback


From: Jim Meyering
Subject: Re: coreutils-4.5.12 build feedback
Date: Wed, 02 Apr 2003 22:48:23 +0200

"Nelson H. F. Beebe" <address@hidden> wrote:
> I've done builds of coreutils-4.5.12 in 40 compilation environments on
> 17 Unix platforms.  On each platform, I've got successful validation
> runs for at least one compilation environment, and have installed the
> new coreutils version.
>
> On two platforms, there was a failure of "make check" because a
> working perl is not available (HP-UX 10.01 was perl-4.0, and
> NetBSD-1.6 has no perl at all, and I've so far been unable to build it
> there).  On these, "make check" fails with something like this:
>
>       make[1]: Entering directory 
> `/home/beebe/9000_712/build/coreutils-4.5.12/doc'
>       grep timezone ./*.texi && exit 1 || :
>       grep '\$@"' ./*.texi && exit 1 || :
>       /missing perl -ne \
>         '/\bPOSIX\b/ && !/address@hidden/ && !/^\* / || /{posix}/ and 
> print,exit 1' \
>         ./*.texi 2> /dev/null && : || exit 1
>       make[1]: Leaving directory 
> `/home/beebe/9000_712/build/coreutils-4.5.12/doc'
>       make[1]: *** [check-texinfo] Error 1
>       18.9u 1.3s 0:23 88%

Hi Nelson!

Thank you for all the testing.
I've fixed that with two changes:

        * Makefile.am (check-texinfo): Don't fail if perl is missing.
        Reported by Nelson Beebe.

Index: Makefile.am
===================================================================
RCS file: /fetish/cu/doc/Makefile.am,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -p -u -r1.23 -r1.24
--- Makefile.am 5 Feb 2003 20:39:59 -0000       1.23
+++ Makefile.am 1 Apr 2003 22:16:10 -0000       1.24
@@ -30,10 +30,12 @@ $(INFO_DEPS): $(EXTRA_DIST)
 
 # List words/regexps here that should not appear in the texinfo documentation.
 check-texinfo:
-       grep timezone $(srcdir)/*.texi && exit 1 || :
-       grep '\$$@"' $(srcdir)/*.texi && exit 1 || :
-       $(PERL) -ne \
+       fail=0; \
+       grep timezone $(srcdir)/*.texi && fail=1; \
+       grep '\$$@"' $(srcdir)/*.texi && fail=1; \
+       $(PERL) -e 1 && { $(PERL) -ne \
          '/\bPOSIX\b/ && !/address@hidden/ && !/^\* / || /{posix}/ and 
print,exit 1' \
-         $(srcdir)/*.texi 2> /dev/null && : || exit 1
+         $(srcdir)/*.texi 2> /dev/null || fail=1; }; \
+       exit $$fail
 
 check: check-texinfo

The other change was here
(to fix the improper reference to `/missing' above):

        * perl.m4 (jm_PERL): Use $am_missing_run, not undefined $missing_dir.

Index: m4/perl.m4
===================================================================
RCS file: /fetish/cu/m4/perl.m4,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -p -u -r1.5 -r1.6
--- m4/perl.m4  12 Aug 2001 13:26:00 -0000      1.5
+++ m4/perl.m4  2 Apr 2003 14:43:41 -0000       1.6
@@ -1,4 +1,4 @@
-#serial 4
+#serial 5
 
 dnl From Jim Meyering.
 dnl Find a new-enough version of Perl.
@@ -20,7 +20,7 @@ AC_DEFUN([jm_PERL],
 
   found=no
   AC_SUBST(PERL)
-  PERL="$missing_dir/missing perl"
+  PERL="$am_missing_run perl"
   for perl in $candidate_perl_names; do
     # Run test in a subshell; some versions of sh will print an error if
     # an executable is not found, even if stderr is redirected.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]