[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: coreutils-5.1.0 build feedback
From: |
Andreas Schwab |
Subject: |
Re: coreutils-5.1.0 build feedback |
Date: |
Thu, 08 Jan 2004 14:46:16 +0100 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> "Nelson H. F. Beebe" <address@hidden> wrote:
>> On DEC Alpha GNU/Linux, the coreutils-5.1.0 test suite had one failure:
>>
>> FAIL: fold
>
> Here's a patch for that one.
> This was due to the use of x2nrealloc with the address of an `int'
> as it's 2nd argument. The problem shows up on systems where
> int and size_t have different sizes.
Here is another portability patch:
--- coreutils-5.1.0/src/stat.c.~1~ 2003-11-05 04:46:47.000000000 +0100
+++ coreutils-5.1.0/src/stat.c 2004-01-08 14:37:44.000000000 +0100
@@ -308,9 +308,9 @@ human_fstype (STRUCT_STATVFS const *stat
return (char *) type;
{
- static char buf[sizeof "UNKNOWN (0x%x)" - 2
+ static char buf[sizeof "UNKNOWN (0x%lx)" - 2
+ 2 * sizeof (statfsbuf->f_type)];
- sprintf (buf, "UNKNOWN (0x%x)", statfsbuf->f_type);
+ sprintf (buf, "UNKNOWN (0x%lx)", (unsigned long) statfsbuf->f_type);
return buf;
}
#endif
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- Re: coreutils-5.1.0 build feedback,
Andreas Schwab <=