[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "cvsu --list" during distcheck
From: |
Jim Meyering |
Subject: |
Re: "cvsu --list" during distcheck |
Date: |
Tue, 13 Jan 2004 13:44:14 +0100 |
Alexandre Duret-Lutz <address@hidden> wrote:
> Hi Jim. I've got another problem with this while trying to test
> the upcoming automake 1.8.1 on coreutils 5.1.0.
>
> The use of cvsu in distcheck rules prevents users to run `make
> distcheck' (because CVS/Entries does not exist in released
> tarballs).
>
> I think this is unfortunate for two reasons
>
> - I expect people who send patches to distcheck their changes
> first. Obviously they can't.
>
> - I do not think a package should dictate users which tools
> they must use for source management.
>
> I'd suggest that this test be disabled if cvsu or CVS/Entries is
> missing, or moved to a separate target (cvsdistcheck?) that
> depends on distcheck.
Hi Alexandre!
Thanks for reporting that.
I've fixed it with this change:
* Makefile.maint (po-check): Ensure that cvsu works before using it.
Index: Makefile.maint
===================================================================
RCS file: /fetish/cu/Makefile.maint,v
retrieving revision 1.166
retrieving revision 1.167
diff -u -p -u -r1.166 -r1.167
--- Makefile.maint 8 Dec 2003 10:17:16 -0000 1.166
+++ Makefile.maint 12 Jan 2004 14:06:55 -0000 1.167
@@ -230,6 +230,7 @@ m4-check:
# Verify that all source files using _() are listed in po/POTFILES.in.
# FIXME: don't hard-code src/false.c below; use a more general mechanism.
po-check:
+ ( cvsu --list ) > /dev/null 2>&1 || : && \
if test -f po/POTFILES.in; then \
grep -E -v '^(#|$$)' po/POTFILES.in \
| grep -v '^src/false\.c$$' | sort > address@hidden;
\