bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-5.1.3 released: bug-fix-only, candidate for stable 5.2.0


From: Jim Meyering
Subject: Re: coreutils-5.1.3 released: bug-fix-only, candidate for stable 5.2.0
Date: Wed, 11 Feb 2004 15:23:57 +0100

address@hidden (Michael Elizabeth Chastain) wrote:
...
> mec>   This is a bug in tests/wc/Makefile.in.  $< is defined only for
> mec>   inference rules and .DEFAULT, not for explicit rules.  See:
>
> jim> Many of the coreutils Makefiles use that construct, and it's
> jim> ok as long as their rules rarely need to be run.
> jim> Maybe you accidentally modified tests/Makefile.am.in, wc/Test.pm,
> jim> or another dependent?  Otherwise, that rule shouldn't trigger.
>
> No, I am running out of a pristine source directory unpacked straight
> from the tarball, with nothing else done to it first.  I don't
> re-use the source dir from one configuration to another -- every run
> starts with a fresh 'tar xjf ...'.
>
> That use of $< in tests/wc/Makefile.am does not conform to Single Unix
> Specification v3.  How about just doing this and conforming:
>
>   sed -n '1,/^##test-files-begin/p' $(srcdir)/../Makefile.am.in > 
> address@hidden

I've investigated a little and suspect that the rebuild happens
in tests/wc because the time stamp on tests/wc/Makefile.am
is exactly the same as the one on its dependent, tests/Makefile.am.in.
GNU make doesn't rebuild in that case, but HPUX's make does, hence
the failure you noticed.

In any case, I've changed both uses of $< in tests/Makefile.am.in.
All of the affected tests/*/Makefile.am files are generated from that template.

Index: tests/Makefile.am.in
===================================================================
RCS file: /fetish/cu/tests/Makefile.am.in,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -p -u -r1.7 -r1.8
--- tests/Makefile.am.in        18 Oct 2003 06:39:04 -0000      1.7
+++ tests/Makefile.am.in        11 Feb 2004 11:46:34 -0000      1.8
@@ -23,9 +23,9 @@ check: $(maint_gen)
 
 $(srcdir)/Makefile.am: ../Makefile.am.in Test.pm $(mk_script)
        rm -f $@ address@hidden
-       sed -n '1,/^##test-files-begin/p' $< > address@hidden
+       sed -n '1,/^##test-files-begin/p' $(srcdir)/../Makefile.am.in > 
address@hidden
        tool=`echo $(subdir)|sed 's/^tests.//;s/-test//'`; \
          echo "x = $$tool" >> address@hidden
        $(PERL) -I$(srcdir) -w -- $(mk_script) $(srcdir) --list >> 
address@hidden
-       sed -n '/^##test-files-end/,$$p' $< >> address@hidden
+       sed -n '/^##test-files-end/,$$p' $(srcdir)/../Makefile.am.in >> 
address@hidden
        mv address@hidden $@

> Anyways, if you want to put up another tarball, I'll be happy to churn
> it again.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]