[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils patch to align buffers better

From: Jim Meyering
Subject: Re: coreutils patch to align buffers better
Date: Thu, 15 Apr 2004 12:55:07 +0200

Paul Eggert <address@hidden> wrote:
> Following up on my previous email, here's a proposed performance patch
> for coreutils.  I can't measure any performance improvements on my
> host, but I suspect that aligning I/O buffers can make a real
> difference with some device drivers on some hosts, and it shouldn't
> hurt on other hosts.

Thanks.  I've applied that.

> 2004-04-13  Paul Eggert  <address@hidden>
>       Use page-aligned buffers whenever we bother to do I/O using buffer
>       sizes that are tailored for the files.
>       * src/cat.c: Include getpagesize.h.
>       * src/copy.c: Likewise.
>       * src/shred.c: Likewise.
>       * src/split.c: Likewise.
>       * src/cat.c (main): Align I/O buffers to page boundaries.
>       * src/copy.c (copy_reg): Likewise.
>       * src/shred.c (dopass): Likewise.
>       * src/split.c (main): Likewise.
>       * src/dd (ROUND_UP_OFFSET, PTR_ALIGN): Remove.
>       All uses replaced by ptr_align.
>       * src/od.c (gcd, lcm): Remove; now in system.h.
>       * src/system.h (gcd, lcm, ptr_align): New functions.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]