Re: patch from Oct 2003 for dd's error-handling code [Re: dd bug

[Jim Meyering]

Paul Eggert <address@hidden> wrote:

> Jim Meyering <address@hidden> writes:
>
>> If you send me a patch that applies cleanly (the patch below gets
>> six failed hunks), I'll test it.
>
> OK, thanks, here's a clean patch.  I don't know how to test it easily,
> though, since one needs a bad device (with I/O errors) to really test
> it.

Thanks.
I've tested and checked it in.

It wasn't hard to test, using an old floppy that had given me I/O errors
a few years ago.

Running this, pre-patch,

  dd if=/dev/fd0 of=/t/floppy-new bs=720k conv=sync,noerror

dd appeared to infloop.  When I interrupted it, the output file
had grown to over 60M.

With the patch, it behaved properly:

  $ ./dd if=/dev/fd0 of=/t/floppy-new bs=720k conv=sync,noerror
  ./dd: reading `/dev/fd0': Input/output error
  1+1 records in
  2+0 records out
  1+1 records in
  2+0 records out
  $ lst /t/floppy-new
  -rw-r--r--  1 meyering meyering 1474560 Jun  3 16:30 /t/floppy-new