2004-08-13 Dmitry V. Levin * lib/userspec.c (parse_user_spec): Fix USER.GROUP parsing bug introduced by change made on 2004-07-28. * tests/chown/dot: New test for the USER.GROUP regression. * tests/chown/Makefile.am (TESTS): Add dot. --- lib/userspec.c.orig 2004-08-09 22:44:50 +0400 +++ lib/userspec.c 2004-08-13 19:42:46 +0400 @@ -225,8 +225,9 @@ parse_user_spec (const char *spec_arg, u unsigned long int tmp_long; if (! (xstrtoul (u, NULL, 10, &tmp_long, "") == LONGINT_OK && tmp_long <= MAXUID)) - return _(E_invalid_user); - *uid = tmp_long; + error_msg = E_invalid_user; + else + *uid = tmp_long; } } else --- tests/chown.orig/dot 1970-01-01 03:00:00 +0300 +++ tests/chown/dot 2004-08-13 20:33:33 +0400 @@ -0,0 +1,53 @@ +#!/bin/sh +# make sure chown USER.GROUP works. + +if test "$VERBOSE" = yes; then + set -x + chown --version +fi + +pwd=`pwd` +t0=`echo "$0" |sed 's,.*/,,'`.tmp; tmp=$t0/$$ +trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status' 0 +trap 'status=$?; (exit $status); exit $status' 1 2 13 15 + +fail=1 +while :; do + mkdir -p $tmp || break + cd $tmp || break + + id_u=`id -u` || break + test -n "$id_u" || break + + id_un=`id -un` || break + test -n "$id_un" || break + + id_g=`id -g` || break + test -n "$id_g" || break + + id_gn=`id -gn` || break + test -n "$id_gn" || break + + fail=0 + break +done + +if test $fail = 1; then + echo "$0: failure in testing framework" 1>&2 + (exit 1); exit 1 +fi + +fail=1 +while :; do + chown "$id_u:$id_g" . || break + chown "$id_un:$id_gn" . || break + chown "$id_u.$id_g" . || break + case "$id_un" in + *.*) ;; + *) chown "$id_un.$id_gn" . || break ;; + esac + fail=0 + break +done + +(exit $fail); exit $fail --- tests/chown.orig/Makefile.am 2004-05-16 18:10:17 +0400 +++ tests/chown/Makefile.am 2004-08-13 20:35:58 +0400 @@ -2,6 +2,7 @@ AUTOMAKE_OPTIONS = 1.4 gnits TESTS = \ + dot \ deref \ basic EXTRA_DIST = $(TESTS)