[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Another testsuite nit: `set -'
From: |
Eric Blake |
Subject: |
Another testsuite nit: `set -' |
Date: |
Tue, 26 Apr 2005 16:51:15 +0000 |
The testsuite had several uses of `set - $list', such that $list could safely
begin with `-'. But 1) POSIX has obsoleted this usage, and 2) in several
shells (at least ash and bash), using - instead of -- as the separator gives
the shell the right to reset -v and -x, which kills the trace when VERBOSE=yes.
In all four cases patched below, it is easily verifiable that the expanded
arguments at those points cannot start with -, so a separator is not needed
since the expansion will not be confused with options; but if you prefer to use
the autoconf approach instead of my patch, rewrite each offending line as `set
x $list; shift'.
The other portability fix is that on cygwin, mkdir(2) executed from a directory
that has ACLs propagates ACLs to the new directory (as a byproduct of how
Windows NTFS permissions are mapped to POSIX semantics). There are several
other tests in the testsuite that are not tolerant of ACLs, but at least
mkdir/perm can be fixed now as long as we are fixing `set -'.
$ ls -ld .
drwxrwxrwx+ 16 Administrators Domain Users 12288 Apr 26 10:42 ./
$ mkdir dir
$ ls -ld dir
drwxr-xr-x+ 2 eblake Domain Users 0 Apr 26 10:42 dir/
$ getfacl dir
# file: dir
# owner: eblake
# group: Domain Users
user::rwx
group::r-x
mask:rwx
other:r-x
default:user::rwx
default:group::r-x
default:other:r-x
2005-04-26 Eric Blake <address@hidden> (tiny change)
* tests/misc/nice (tests): Don't use `set -', it resets -x.
* tests/mv/part-hardlink (fail): Likewise.
* tests/stty/row-col-1 (tests): Likewise.
* tests/mkdir/perm (tests): Likewise. Also, allow for default
directory ACLs.
--
Eric Blake
coreutils.patch
Description: Binary data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Another testsuite nit: `set -',
Eric Blake <=