[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: {base,dir}name // semantics
From: |
Eric Blake |
Subject: |
Re: {base,dir}name // semantics |
Date: |
Mon, 11 Jul 2005 07:02:14 -0600 |
User-agent: |
Mozilla Thunderbird 1.0.2 (Windows/20050317) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Paul Eggert on 7/9/2005 2:25 PM:
>
>>should this patch be made globally, or should it be limited to only
>>systems that have a distinct //, leaving other platforms to continue
>>having just a single slash returned?
>
> Limit it to just those systems, please.
I originally thought the change would be limited to the gnulib dirname
module, but I guess the change is worthy of documentation and NEWS. I
also realized that on systems where 'basename //' returns '/', POSIX
requires 'basename // /' to also return '/'. But on systems where
'basename //' returns '//', POSIX requires 'basename // /' to return '//',
and this requires a patch to src/basename.c. Would it be better to patch
remove_suffix() to return early if the name parameter ends in slash (in
which case name must have been "/" or "//"), or to patch main() to not
even call remove_suffix() in that case?
Boy, I really need to get my copyright papers completed - I'll try
pestering my employer again.
- --
Life is short - so eat dessert first!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFC0m3W84KuGfSFAYARAtLNAJ9q7PPmEiABEVwKDCO5nFQviq7vzQCdGY/j
MfvawlDZNdwYFTg/xdrq35w=
=Inqk
-----END PGP SIGNATURE-----