Re: coreutils-5.90 released

[Paul Eggert]

address@hidden (Eric Blake) writes:

> dd.c:1661: warning: long unsigned int format, size_t arg (arg 5)

Thanks; I installed this patch.

Jim -- I'm not sure what version number you want at the top of
ChangeLog so I left it out for now.

2005-09-29  Paul Eggert  <address@hidden>

        * src/dd.c (main): Don't assume size_t has the same width
        as unsigned long.  Problem reported by Eric Blake.

--- src/dd.c    16 Sep 2005 09:35:47 -0000      1.187
+++ src/dd.c    30 Sep 2005 05:07:11 -0000      1.188
@@ -1652,13 +1652,14 @@ main (int argc, char **argv)
       if (seek_records != 0 && !(conversions_mask & C_NOTRUNC))
        {
          uintmax_t size = seek_records * output_blocksize;
+         unsigned long int obs = output_blocksize;
 
          if (OFF_T_MAX / output_blocksize < seek_records)
            error (EXIT_FAILURE, 0,
                   _("offset too large: "
                     "cannot truncate to a length of seek=%"PRIuMAX""
                     " (%lu-byte) blocks"),
-                  seek_records, output_blocksize);
+                  seek_records, obs);
 
          if (ftruncate (STDOUT_FILENO, size) != 0)
            {