Re: coreutils-5.92:du not AIX largefile safe --

[Paul Townsend]

On Fri, 04 Nov 2005 12:20:08 +0100, Jim Meyering wrote:
>--=-=-=
>
>Paul Townsend <address@hidden> wrote:
>> I put the above plus a couple of other commands in a script.  Below is
>> the output of `ksh -xv tst'.
>
>I've applied your patch and written a test for the bug.
>Would you please see if it detects the problem with the previous
>version of du and that it succeeds with your patch?
>
>If you put the attached file in coreutils-5.9/tests/du/, make it executable,
>and then run it like this (it relies on a new file, tests/very-expensive,
>which you won't have -- just touch it to create an empty file):
>
>  env srcdir=. ./2g
>
>it should fail when src/du is the old one and succeed with the new.

Worked as expected.  A couple of ideas/questions about test script.

1) On line 15, "'expensive'" should be "'very expensive'"?
2) Script writes "big" relative to current directory.  Unfortunately,
   not all filesystems have that much free space so I added a TMPDIR
   variable that can point at a filesystem that has sufficient space.  I
   don't know how it should be set though (../very-expensive maybe??).
3) Wouldn't `cmp -s' be better?  Without the "-s", you see the `cmp'
   message about differences at "char 1, line 1".

Below I have delineated the mods I made.

--    Paul Townsend

--- /home/clerk/u76/aab/junk    Tue Nov  8 02:38:38 2005
+++ 2g  Tue Nov  8 01:12:39 2005
@@ -10,11 +10,11 @@

 . $srcdir/../envvar-check

-# Creating a 2GB file counts as `expensive'.
+# Creating a 2GB file counts as `very expensive'.
 . $srcdir/../very-expensive

 pwd=`pwd`
-t0=`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$
+t0=${TMPDIR+${TMPDIR}/}`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$
 trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status' 0
 trap '(exit $?); exit $?' 1 2 13 15