Re: Coreutils 5.93 patched with 5.91 POSIX ACL patch test results - Update

[Albe]

Hi,

I did some more test on different linux installations.

First of all i have to say that the result reported were the same on 
both mentioned installation and a mandrivia 2006 one. The coreutils used 
were at first acl patched. But the result reported replicated also on 
the official packages for both 5.2.1 and 5.93.
These installations where both on virtual machines.

Today i did some more test. I thought that the presence of VMWare tools 
modules on the system could affect the results, since they were not 
installed at first. I installed them, rerun the test and obtained the 
same results on both virtual machines.

To take away any doubt i did the same tests (coreutils 5.2.1 and 5.93) 
on real machines linux installations. They are a Mandrake 10, a Redhat 9 
and a Slackware 10. On the Mandrake and Redhat i obtained the same  
errors, while the slackware didn't have any.

The following is the required debug dump of the fail-perm on the 
original slackware 10.2 virtual machine:

make: Entering directory `/root/coreutils-5.93/tests/cp'
make  check-TESTS
make[1]: Entering directory `/root/coreutils-5.93/tests/cp'
+ cp --version
cp (GNU coreutils) 5.93
Copyright (C) 2005 Free Software Foundation, Inc.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License <http://www.gnu.org/licenses/gpl.html>.
There is NO WARRANTY, to the extent permitted by law.

Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering.
+ PRIV_CHECK_ARG=require-non-root
+ . ./../priv-check
++ case "$PRIV_CHECK_ARG" in
++ who='by an unprivileged user'
+++ id -u
++ my_uid=0
++ test 0 = 0
++ case $my_uid in
++ test 0 = 0
++ : nobody
+++ id -u nobody
++ coreutils_non_root_uid=99
++ test 0 = 0
++ test 99 = 0
++ give_msg=no
++ case $PRIV_CHECK_ARG:$my_uid in
++ setuidgid nobody test -w .
++ exec setuidgid nobody env 
PATH=/root/coreutils-5.93/tests/cp/../../src:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/bin:/usr/X11R6/bin:/usr/games:/opt/www/htdig/bin:/usr/lib/java/bin:/usr/lib/java/jre/bin:/opt/kde/bin:/usr/lib/qt/bin:/usr/share/texmf/bin 
./fail-perm
+ cp --version
cp (GNU coreutils) 5.93
Copyright (C) 2005 Free Software Foundation, Inc.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License <http://www.gnu.org/licenses/gpl.html>.
There is NO WARRANTY, to the extent permitted by law.

Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering.
+ PRIV_CHECK_ARG=require-non-root
+ . ./../priv-check
++ case "$PRIV_CHECK_ARG" in
++ who='by an unprivileged user'
+++ id -u
++ my_uid=99
++ test 0 = 0
++ case $my_uid in
++ test 99 = 0
++ give_msg=no
++ case $PRIV_CHECK_ARG:$my_uid in
++ test no = yes
++ pwd
+ pwd=/root/coreutils-5.93/tests/cp
++ echo ./fail-perm
++ sed 's,.*/,,'
+ t0=fail-perm.tmp
+ tmp=fail-perm.tmp/15251
+ trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit 
$status' 0
+ trap '(exit $?); exit' 1 2 13 15
+ framework_failure=0
+ mkdir -p fail-perm.tmp/15251
+ cd fail-perm.tmp/15251
./fail-perm: line 17: cd: fail-perm.tmp/15251: Not a directory
+ framework_failure=1
+ mkdir D D/D
mkdir: cannot create directory `D': File exists
mkdir: cannot create directory `D/D': File exists
+ framework_failure=1
+ touch D/a
+ chmod 0 D/a
+ chmod 500 D
+ test 1 = 1
+ echo 'failure in testing framework'
failure in testing framework
+ exit 1
+ status=1
+ cd /root/coreutils-5.93/tests/cp
./fail-perm: line 26: cd: /root/coreutils-5.93/tests/cp: Not a directory
+ chmod -R u+rwx fail-perm.tmp
+ rm -rf fail-perm.tmp
+ exit 1
FAIL: fail-perm
======================================
1 of 1 tests failed
Please report to address@hidden
======================================
make[1]: *** [check-TESTS] Error 1
make[1]: Leaving directory `/root/coreutils-5.93/tests/cp'
make: *** [check-am] Error 2
make: Leaving directory `/root/coreutils-5.93/tests/cp'


I remain at disposal


Alberto



Albe wrote:
> Inizio messaggio inoltrato:
>
> > *Da: *Jim Meyering <address@hidden <mailto:address@hidden>>
> > *Data: *01 dicembre 2005 18:10:25 GMT+01:00
> > *A: *Albe <address@hidden <mailto:address@hidden>>
> > *Cc: address@hidden <mailto:address@hidden>
> > *Oggetto: **Re: Coreutils 5.93 patched with 5.91 POSIX ACL patch test 
> > results - Update*
> >
> > Albe <address@hidden <mailto:address@hidden>> wrote:
> > > as a follow up to my previous email, I've tested the vanilla 5.93 and
> > > 5.2.1 versions of coreutils obtaining the same FAIL list.
> > >
> > > Is it my linux installation or are those errors somehow expected?
> > >
> > > currently I've installed a slackware 10.2 with the latest attr and acl
> > > libs compiled and installed. In fact setfacl and getfacl work well.
> >
> > Thanks for the report, but I'd rather not spend
> > time investigating that right now.
> >
> > If you can wait a little longer, changes similar to those should
> > be integrated into the trunk within the next week or two.
> Inizio messaggio inoltrato:
>
> > *Da: address@hidden <mailto:address@hidden> (Bob Proulx)
> > *Data: *01 dicembre 2005 18:05:59 GMT+01:00
> > *A: *Albe <address@hidden <mailto:address@hidden>>
> > *Cc: address@hidden <mailto:address@hidden>
> > *Oggetto: **Re: Coreutils 5.93 patched with 5.91 POSIX ACL patch test 
> > results - Update*
> >
> > Albe wrote:
> > > as a follow up to my previous email, I've tested the vanilla 5.93 and 
> > > 5.2.1 versions of coreutils obtaining the same FAIL list.
> >
> > Good.  Because upstream can't be responsible for downstream patches.
> >
> > > Is it my linux installation or are those errors somehow expected?
> >
> > Those tests are expected to pass.
> >
> > Would you please do this.  Pick a test that fails and get more
> > information on why.  Let's start with fail-perm test:
> >
> >   env DEBUG=yes VERBOSE=yes make check -C tests/cp TESTS=fail-perm > 
> > log 2>&1
> >
> > And then send the contents of `log' to the mailing list?  That output
> > should be relatively small and give us the information to see what is
> > happening with it.
> >
> > Bob