[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ACL patch feedback

From: Andreas Gruenbacher
Subject: Re: ACL patch feedback
Date: Tue, 6 Dec 2005 13:28:53 +0100
User-agent: KMail/1.8


[Resent to the list, too.]

[Jim: note that the version I've sent before made chmod_or_fchmod non-static; 
the attached version fixes this, and otherwise is identical.]

here is a new version. I've merged the two patches; one without the other 
isn't useful anyway, and I got in a mess splitting things cleanly between the 
two. This now improves how autoconf's findings are used in acl.c, and cleans 
up things a bit more. Big ChangeLog entry at the end.

What I'm puzzled by is the two lines that test for x->copy_as_regular in 
copy_reg and copy_internal, and do the chmod depending on that. I don't see 
what the intention of those is, and the semantics seem to be correct without 
them. We may still need to add those checks back in though.

        (x->copy_as_regular || S_ISREG (src_sb->st_mode)

        (x->copy_as_regular || S_ISREG (src_type) || S_ISDIR (src_type))

The patch doesn't have copy_acl or set_acl support for Solaris and 
Solaris-like systems. I can later send the code (in a second patch) if you 
want, but I can't test it.

> mv-acl-test.diff
>       A minor test case fix.

This one got lost: please apply.


Andreas Gruenbacher <address@hidden>
SUSE Labs, SUSE LINUX Products GmbH / Novell Inc.

Attachment: mv-acl-test.diff
Description: Text Data

Attachment: next-version-of-acl-patch.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]