Re: bug in chdir-safer

[Paul Eggert]

Jim Meyering <address@hidden> writes:

> I recognize the value of the added open-with-O_WRONLY,
> but note that it's wasted on modern Linux systems.

Come to think of it, it's wasted on any system that conforms to POSIX,
since POSIX requires that open-with-write-access must fail on
directories.  I think I'm responsible for that O_WRONLY business, but
I don't recall what I tried it out on -- perhaps SunOS 4?

I don't think it's worth worrying about non-POSIX systems, so I'll
prepare a patch that undoes that stuff (both here and elsewhere).
There are some related things that need normalizing, too, e.g.,
whether to open directories with O_NONBLOCK, O_DIRECTORY, and the like.