bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Some minor issues with 5.96


From: Ralf Wildenhues
Subject: Re: Some minor issues with 5.96
Date: Sat, 27 May 2006 15:07:23 +0200
User-agent: Mutt/1.5.11

* Ralf Wildenhues wrote on Sat, May 27, 2006 at 02:53:32PM CEST:
> - Let's have `make check' be portable, so users can easily use it.
>   Patch below.

>       * doc/Makefile.am: Use `$(EGREP)' instead of `grep -E'.

Hmm.  Seems that wasn't enough.
| grep: RE error in setfilename|{filename} syntax error
| grep: RE error in @vindex PATH$|@env{PATH} syntax error

Updated patch.

Cheers,
Ralf

        * doc/Makefile.am: Use `$(EGREP)' instead of `grep -E'.
        Do not use `{' outside of brackets.

Index: doc/Makefile.am
===================================================================
RCS file: /sources/coreutils/coreutils/doc/Makefile.am,v
retrieving revision 1.36
diff -u -r1.36 Makefile.am
--- doc/Makefile.am     19 Jun 2005 13:43:50 -0000      1.36
+++ doc/Makefile.am     27 May 2006 13:06:46 -0000
@@ -40,14 +40,14 @@
        $(EGREP) '$(_W)NUL$(W_)' $(srcdir)/*.texi && fail=1; \
        grep '\$$@"' $(srcdir)/*.texi && fail=1; \
        grep -n '[^[:punct:address@hidden' $(srcdir)/*.texi && fail=1; \
-       grep -n filename $(srcdir)/*.texi|grep -vE 'setfilename|{filename}' \
+       grep -n filename $(srcdir)/*.texi|$(EGREP) -v 
'setfilename|[{]filename[}]' \
          && fail=1; \
        $(PERL) -e 1 2> /dev/null && { $(PERL) -ne \
          '/\bPOSIX\b/ && !/address@hidden/ && !/^\* / || /{posix}/ and 
print,exit 1' \
          $(srcdir)/*.texi 2> /dev/null || fail=1; }; \
-       grep -iwE 'builtins?' $(srcdir)/*.texi && fail=1; \
-       grep -iwE 'path(name)?s?' $(srcdir)/*.texi \
-         | grep -vE '@vindex PATH$$|@env{PATH}' && fail=1; \
+       $(EGREP) -iw 'builtins?' $(srcdir)/*.texi && fail=1; \
+       $(EGREP) -iw 'path(name)?s?' $(srcdir)/*.texi \
+         | $(EGREP) -v '@vindex PATH$$|@env[{]PATH[}]' && fail=1; \
        exit $$fail
 
 check: check-texinfo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]