bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: uniq i18n implementation


From: Pádraig Brady
Subject: Re: uniq i18n implementation
Date: Mon, 14 Aug 2006 19:57:05 +0100
User-agent: Mozilla Thunderbird 1.0.8 (X11/20060502)

Paul Eggert wrote:
> Pádraig Brady <address@hidden> writes:
> 
> 
>>There seems to be serious overhead with strcoll on glibc-2.3.5-10 at least.
> 
> 
> We can fix the performance problem for that particular test case as
> follows.  I installed this (diff -pubw format):
> 
> 2006-08-14  Paul Eggert  <address@hidden>
> 
>       * memcoll.c (memcoll): Optimize for the common case where the
>       arguments are bytewise equal.

Cool, that's a good optimization,
loads of improvement with not much downside:

1 = coreutils 5.97 uniq
2 = coreutils 5.97 uniq with above patch

a = ascii long lines, with all same length (85 chars), and 26 identical lines 
for every 27
b = ascii long lines, with all same length (85 chars), and all adjacent lines 
different

LANG=en_IE.UTF8
\  1       2
 ---------------
a| 5.300   0.286
b| 0.438   0.449


Pádraig




reply via email to

[Prev in Thread] Current Thread [Next in Thread]