bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "chmod a+rwx A B" doesn't chmod A before chmoding B


From: Paul Eggert
Subject: Re: "chmod a+rwx A B" doesn't chmod A before chmoding B
Date: Wed, 20 Sep 2006 14:48:11 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Jim Meyering <address@hidden> writes:

> Regarding your conceptually separate change that adds the check
> for fts_close failure, you're welcome to add it back, especially
> if you can come up with a test case that triggers it.

Those changes aren't needed any more, since the programs are about to
exit anyway.  They were needed only because yesterday's code sometimes
accessed the working directory even after fts_close was called.  It no
longer does this, so there's no longer any need to check the return
values from fts_close.

I suppose we could even remove the calls to fts_close.  That'd make
the programs a bit smaller and faster, at a slight cost to conceptual
cleanliness.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]