bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-6.3: c89 patch insufficent


From: Matthew Woehlke
Subject: Re: coreutils-6.3: c89 patch insufficent
Date: Wed, 11 Oct 2006 18:08:25 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060909 Thunderbird/1.5.0.7 Mnenhy/0.7.4.0

Michael Deutschmann wrote:
coreutils-6.3 includes a patch, c99-to-c89.diff, to allow it to be
compiled on platforms that don't support declarations after statements.
However, this patch is not sufficent -- I had to fix two other areas to
get coreutils to compile under GCC 2.95.3.

I've appended my fixes.  They are to be applied after the existing
c99-to-c89.diff.
[snip patch]

For some reason, I also appear to need the following on NSK/OSS, but not on any of the other platforms that lacked c99 compilers.

====
diff -u ../coreutils-6.3-tmp/lib/rename-dest-slash.c lib/rename-dest-slash.c
--- ../coreutils-6.3-tmp/lib/rename-dest-slash.c 2006-10-09 12:50:22.000000000 -0700
+++ lib/rename-dest-slash.c     2006-10-11 15:07:01.000000000 -0700
@@ -41,11 +41,11 @@
 static inline bool
 has_trailing_slash (char const *file, size_t len)
 {
+  char last = file[len - 1];
+
   /* Don't count "/" as having a trailing slash.  */
   if (len <= FILE_SYSTEM_PREFIX_LEN (file) + 1)
     return false;
-
-  char last = file[len - 1];
   return ISSLASH (last);
 }

====
(that's a trailing blank line)

--
Matthew
Will your shell have salvation? Only if it's Bourne Again.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]