Re: Make check fails at one-file-system

[Jim Meyering]

"Jon Grosshart" <address@hidden> wrote:
> Alex van Hout <address@hidden> wrote:
>> Afther building coreutils 6.7, make check fails on the rm check:
>> one-file-system.
>>
>> The check in "src/rm/one-file-system" is to compare the output of rm to a
>> predefined string.
>>
>> The expected string at "one-file-system" line: 50 is:
>> rm: skipping `a/b', since it's on a different device
>>
>> The output generated by rm is:
>> rm: skipping `a/b', since it's on a different device: Is a directory
>>
>> Sysspecs:
>> Kernel  2.6.18.2
>> gcc 4.1.1
>> glibc: 2.5
>
> Any word on a resolution? I'm facing the same error on:
> kernel 2.6.18.6
> gcc 4.1.1
> glibc 2.4

Thanks to both of you.
I've just fixed it:

        * src/remove.c (remove_dir): Don't use errno in diagnostic.
        Root-only test failure reported by Alex van Hout and Jon Grosshart in
        <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/9415/focus=9415>.

diff --git a/src/remove.c b/src/remove.c
index 7e86451..fbe7204 100644
--- a/src/remove.c
+++ b/src/remove.c
@@ -1371,7 +1371,7 @@ remove_dir (int fd_cwd, Dirstack_state *ds, char const 
*dir,
             traversal into the current directory, (known as SUBDIR, from ..),
             DIRP's device number is different from CURRENT_DEV.  Arrange not
             to do anything more with this hierarchy.  */
-         error (0, errno, _("skipping %s, since it's on a different device"),
+         error (0, 0, _("skipping %s, since it's on a different device"),
                 quote (full_filename (subdir)));
          free (subdir);
          AD_mark_current_as_unremovable (ds);
--
1.5.0.rc1.g696b