bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: a coreutils release is imminent


From: Jim Meyering
Subject: Re: a coreutils release is imminent
Date: Wed, 21 Mar 2007 16:49:35 +0100

Thomas Schwinge <address@hidden> wrote:
> Here we go.  So far, I didn't run the tests marked as ``root-only'' or
> ``very expensive''.

Thanks for the detailed feedback!

> $ uname -a
> GNU flubber 0.3 GNU-Mach 1.3.99/Hurd-0.3 i686-AT386 GNU

> | SKIP: 8gb

I suppose you already know about the instructions in README for
making the tests produce verbose output...

> Would have to check what's up with that one.  (As well as for the others
> further down the list, the ones where I didn't put specific comments.)
>
> | df: Warning: cannot read table of mounted file systems
> | df: Warning: cannot read table of mounted file systems
> | ../../../tests/du/slink: skipping this test, since `.' is on an XFS file 
> system
> | SKIP: slink
>
> It's for sure not an xfs file system, but an ext2 one.  We don't maintain
> something like `/proc/mounts' or `/etc/mtab', so running `df' without
> explicitly specifying a directory to work on won't work:

Good catch.  It exposed a suboptimality in that script.
Here's a patch that might help.

        Fix a test script not to claim an ext2 file system is of type xfs.
        * tests/du/slink: When using df --local and df --type=TYPE,
        test only the exit code.  Don't bother with stdout.
        Prompted by a report by Thomas Schwinge of an inaccurate diagnostic.

diff --git a/tests/du/slink b/tests/du/slink
index 2167934..8be1a30 100755
--- a/tests/du/slink
+++ b/tests/du/slink
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Ensure that the size of a long-named-symlink is > 0.

-# Copyright (C) 2002, 2003, 2004, 2006 Free Software Foundation, Inc.
+# Copyright (C) 2002-2007 Free Software Foundation, Inc.

 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -34,25 +34,23 @@ cd $tmp || framework_failure=1

 # Determine if `.' is on a local (would non-NFS be sufficient?) file system.
 # On at least some NFS implementations, symlinks never take up space,
-df --local . | tail -n +2 > tmp
+
 # So if this is a non-local file system, skip the test.
-if test -s tmp; then
+if df --local . >/dev/null 2>&1; then
   : # Ok.
 else
   echo "$0: skipping this test, since \`.' is on a non-local file system" 1>&2
   (exit 77); exit 77
 fi

-df --type=xfs . | tail -n +2 > tmp
-if test -s tmp; then
+if df --type=xfs . >/dev/null 2>&1; then
   # At least on Irix-6.5.19, when using an xfs file system,
   # each created symlink (name lengths up to 255) would have a size of `0'.
   echo "$0: skipping this test, since \`.' is on an XFS file system" 1>&2
   (exit 77); exit 77
 fi

-df --type=nfsv3 . | tail -n +2 > tmp
-if test -s tmp; then
+if df --type=nfsv3 . >/dev/null 2>&1; then
   # At least on OSF/1 4.0d, when using an nfsv3 file system,
   # each created symlink can end up having a size of 0.
   echo "$0: skipping this test, since \`.' is on an NFS file system" 1>&2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]