[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Command line parsing of ls, tail and wc with genparse

From: Michael Geng
Subject: Re: [PATCH] Command line parsing of ls, tail and wc with genparse
Date: Sun, 7 Oct 2007 09:47:15 +0200
User-agent: Mutt/1.5.9i

On Sat, Oct 06, 2007 at 05:35:43PM +0200, Jim Meyering wrote:
> address@hidden (Michael Geng) wrote:
> ...
> > file you extracted above is from the wc command. You can watch the genparse
> > generated parser for it from 
> > http://genparse.sourceforge.net/examples/wc_clp.c.
> It's nice to see the continuing improvements.
> I noticed that you transformed the uses of fputs in wc's usage
> function into uses of fprintf in your generated wc_clp.c.
> That is probably ok in most cases, but in some (with a string
> containing "%"), it's not -- unless you escape them.
> Besides, I switched from fprintf to fputs for a reason: so that
> I (and translators) don't have to worry about such escaping.
> In addition, I don't mind that fputs is lighter-weight than fprintf.

Genparse could issue fputs () calls whenever the printed string doesn't contain
arguments. I will probably change this in one of the next genparse releases.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]