Re: new coreutils snapshot

[Jim Meyering]

Mike Frysinger <address@hidden> wrote:
> On Tuesday 23 October 2007, Jim Meyering wrote:
>> Here's another snapshot.
>> FYI, I don't expect to make big changes before the next release[*],
>> which will be of those can't-call-it-stable-but-think-it-is ones.
>
> probably a gnulib issue, but m4/lseek.m4 causes a broken pipe error to be
> shown during configure ... doesnt affect the build, so you can prob just
> consider it a cosmetic issue
>
> as for tests, two rm tests fail when run as root on a Linux system ...
> unreadable and fail-2eperm ... logs attached
> -mike

Thanks for the testing and quick report.

> FAIL: fail-2eperm (exit: 1)
> ===========================

You can avoid this failure if you follow the advice in README.
See the "Running tests as root" section, where it says build
as a regular user, and run tests with e.g.,

  sudo env NON_ROOT_USERNAME=$USER make -k check

> FAIL: unreadable (exit: 1)
> ==========================

I've fixed it like this:

        Don't fail part 2 of tests/rm/unreadable when run as root.
        * tests/rm/unreadable: With UID == 0, expect different results.
        Reported by Mike Frysinger.

diff --git a/tests/rm/unreadable b/tests/rm/unreadable
index 2fbe032..4af8280 100755
--- a/tests/rm/unreadable
+++ b/tests/rm/unreadable
@@ -38,6 +38,7 @@ use strict;
 my $d = "dir-$$";
 my $mkdir = {PRE => sub {mkdir $d,0100 or die "$d: $!\n"}};
 my $prog = 'rm';
+my $uid = $<;

 my @Tests =
     (
@@ -47,8 +48,9 @@ my @Tests =
      ['unreadable-1', '-rf', $d, {EXIT => 0}, $mkdir],

      ['unreadable-2', '-rf', $d,
-      {EXIT => 1},
-      {ERR => "$prog: cannot remove \`$d': Permission denied\n"},
+      {EXIT => $uid == 0 ? 0 : 1},
+      {ERR => $uid == 0 ? ''
+                        : "$prog: cannot remove \`$d': Permission denied\n"},
       {PRE => sub { (mkdir $d,0700 and mkdir "$d/x",0700 and chmod 0100,$d)
                     or die "$d: $!\n"}} ],
     );