[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Mention the new join option --check-order
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] Mention the new join option --check-order |
Date: |
Mon, 18 Feb 2008 00:31:02 +0000 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
James Youngman wrote:
> On Feb 17, 2008 12:16 AM, Pádraig Brady <address@hidden> wrote:
>> James Youngman wrote:
>>> + join now has a --check-order option which causes join to verify that
>>> + the input files are indeed sorted. The option --nocheck-sorted
>>> + turns the check off (the check is currently off by default).
>> I'm not sure it's worth adding this option.
>> If you know to use it, then you already know the input should be sorted?
>> what am I missing?
>
> My original intent was to make it the default, but it turns out that
> the coreutils manual documents a "GNU extension" allowing the input
> not to be sorted, as long as identical join fields are presented on
> each line.
That condition can be easily checked for right?
So you print the warning if you detect unsorted input,
and the above condition is not true.
Also I can't think of any other reason you would input
unsorted keys into `join`, so it would be great if
we could add this functionality with no options at all.
Pádraig.