[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] GNUmakefile build tweaks.
From: |
Jim Meyering |
Subject: |
Re: [PATCH] GNUmakefile build tweaks. |
Date: |
Mon, 03 Mar 2008 21:28:44 +0100 |
Eric Blake <address@hidden> wrote:
> * GNUmakefile: When Makefile is not present, make common targets depend
> on all to trigger nicer error message.
> * configure.ac: If autoconf is new enough, link GNUmakefile into VPATH
> builds.
Thanks. Applied with one tweak: I put all new targets on the same line:
check dist distcheck install: all
> [At this point, I'm wondering if GNUmakefile should also check whether
> configure is present, in which case it suggests reading the hacking
> instructions and running ./bootstrap; although that only affects
> unbootstrapped
> trees, rather than unconfigured trees, so it affects a smaller audience.]
Wouldn't hurt, but maybe not worth it, either...
> For the second change, it is nice to link GNUmakefile into the VPATH build
> tree, so that a VPATH 'make dist' using GNU make picks up all of the
> maintainer
> bonus rules (including those in Makefile.maint). Unfortunately, autoconf 2.61
> AC_CONFIG_LINKS does not support this usage; you need 2.61a.100 or greater.
> On
> the other hand, coreutils already relies on newer autoconf anyway.
>
> [I really wish the FSF lawyers would come to a resolution on how to license
> autoconf under GPLv3+ with exception; autoconf 2.62 has been held up long
> enough.]
Same here.