bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: I: typo in coreutils-v6.10-117-g0ecdb0a


From: Jim Meyering
Subject: Re: I: typo in coreutils-v6.10-117-g0ecdb0a
Date: Tue, 18 Mar 2008 21:36:55 +0100

"Dmitry V. Levin" <address@hidden> wrote:
> Looks like there is a typo in commit v6.10-117-g0ecdb0a,
> it needs s/assert.h/getopt.h/

Good catch.
Thank you.

Even (especially?) for simply things like that,
I appreciate it when people take the time to provide
a "git format-patch" style diff, which includes a proper
ChangeLog entry in the "git commit" log, as below.
Then I can trivially attribute the change and
apply the patch at the same time.

This time, I did it all for you and manually
set the attribution:

>From 29ff7a394390efc6745810c042b4cba059c34141 Mon Sep 17 00:00:00 2001
From: Dmitry V. Levin <address@hidden>
Date: Tue, 18 Mar 2008 20:32:03 +0100
Subject: [PATCH] Correct typo in "make syntax-check" diagnostic.

* Makefile.maint (sc_prohibit_getopt_without_use): s/assert.h/getopt.h/

---
 Makefile.maint |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.maint b/Makefile.maint
index 7a0157b..23a64ee 100644
--- a/Makefile.maint
+++ b/Makefile.maint
@@ -185,7 +185,7 @@ sc_prohibit_getopt_without_use:
                    $$($(CVS_LIST_EXCEPT) | grep '\.c$$')) &&           \
          grep -E -L '\<getopt(_long)? \(' $$files                      \
              | grep . &&                                               \
-           { echo "$(ME): the above files include <assert.h> but don't use it" 
\
+           { echo "$(ME): the above files include <getopt.h> but don't use it" 
\
                  1>&2; exit 1; } || :;                                 \
        else :;                                                         \
        fi
--
1.5.5.rc0.7.g57e83




reply via email to

[Prev in Thread] Current Thread [Next in Thread]