Re: [PATCH] Clarify field delimiter description in uniq --help output

[Jim Meyering]

Pádraig Brady <address@hidden> wrote:
>>From 9228e10c4c68ffd585bbb6e5fd7efbab6f6c5f97 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Mon, 19 May 2008 07:54:07 +0100
> Subject: [PATCH] Clarify field delimiter description in uniq --help output
>
> * src/uniq.c: Clarify in help output that field delimiters are blanks and
> not the larger set of whitespace characters.
>

> Signed-off-by: Pádraig Brady <address@hidden>
> ---
>  src/uniq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/uniq.c b/src/uniq.c
> index 1a54055..3dac9ee 100644
> --- a/src/uniq.c
> +++ b/src/uniq.c
> @@ -165,7 +165,7 @@ Mandatory arguments to long options are mandatory for 
> short options too.\n\
>       fputs (VERSION_OPTION_DESCRIPTION, stdout);
>       fputs (_("\
>  \n\
> -A field is a run of whitespace, then non-whitespace characters.\n\
> +A field is a run of spaces or tabs, then non-blank characters.\n\
>  Fields are skipped before chars.\n\
>  "), stdout);
>       fputs (_("\

Hi Pádraig,

Thanks!
Your summary is right, but the --help change is slightly
inaccurate, since "blank" can mean more than just SPC or TAB.
How about this instead: (I also wrapped the log lines to 72 columns)

>From d275a2bfcb34ba9e12543b5c7b138550976ec235 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
Date: Mon, 19 May 2008 07:54:07 +0100
Subject: [PATCH] doc: clarify field delimiter description in uniq --help output

* src/uniq.c: Clarify in help output that field delimiters are
blanks and not the larger set of whitespace characters.
---
 src/uniq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/uniq.c b/src/uniq.c
index b167bbb..4f0d5c0 100644
--- a/src/uniq.c
+++ b/src/uniq.c
@@ -165,7 +165,7 @@ Mandatory arguments to long options are mandatory for short 
options too.\n\
      fputs (VERSION_OPTION_DESCRIPTION, stdout);
      fputs (_("\
 \n\
-A field is a run of whitespace, then non-whitespace characters.\n\
+A field is a run of blanks, then non-blank characters.\n\
 Fields are skipped before chars.\n\
 "), stdout);
      fputs (_("\
--
1.5.5.1.249.g68ef3