bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: solaris 8 fails to build due to `tr'


From: Jim Meyering
Subject: Re: solaris 8 fails to build due to `tr'
Date: Wed, 11 Jun 2008 14:18:03 +0200

"EXCOFFIER, Denis (CS SYSTEMES INFORMATION)" <address@hidden> wrote:
> In order for my solaris 8 to build correctly coreutils-6.12, i had to modify 
> ./configure in lines 70410 and 70549,
> to add a (forgotten IMHO) space in the second argument of tr (not counting 
> `-s'). See also line 70425. These 2 spaces are
> still missing in coreutils-6.12.29-a16be (dated 2008-06-10).

Thank you!  Bruno Haible fixed the first one just a few hours ago.
I'm including a patch below that fixes the other.

> I had also 2 test failures (ie `FAIL' instead of `PASS' or `SKIP'), but were 
> unable to fix them: test-vc-list-files-git.sh and
> test-vc-list-files-cvs.sh.

Hmm... there's currently no automatic way to enable debugging
for those scripts, so if you don't mind investigating,
just insert "set -x" statements into each and rerun.
I.e., run these commands, then post the contents of the "log" file:

  perl -ni -e '/^tmpdir/ and print "set -x\n"; print' \
    gnulib-tests/test-vc-list-files-*.sh
  make check -C gnulib-tests \
    TESTS='test-vc-list-files-git.sh test-vc-list-files-cvs.sh' > log 1>&2

Here's the patch:

>From b92417057880665eb39326bd655986b677b7e1a4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 11 Jun 2008 14:04:45 +0200
Subject: [PATCH] fix another unportable use of 'tr'

* configure.ac [EXTRA_PROGRAMS]: Add omitted space in second
argument of tr.  Spotted by Denis Excoffier.
---
 THANKS       |    1 +
 configure.ac |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/THANKS b/THANKS
index cb9b098..e1d2089 100644
--- a/THANKS
+++ b/THANKS
@@ -133,6 +133,7 @@ David Malone                        address@hidden
 Dawson Engler                       address@hidden
 Dean Gaudet                         address@hidden
 Deepak Goel                         address@hidden
+Denis Excoffier                     address@hidden
 Dennis Henriksen                    address@hidden
 Dennis Smit                         address@hidden
 Derek Clegg                         address@hidden
diff --git a/configure.ac b/configure.ac
index 464bea2..ac93e1c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -258,7 +258,7 @@ mk="$srcdir/src/Makefile.am"
 v=EXTRA_PROGRAMS
 for gl_i in `sed -n '/^'$v' =/,/[[^\]]$/p' $mk \
     | sed 's/^  *//;/^\$.*/d;/^'$v' =/d' \
-    | tr -s '\\015\\012\\\\' '  '`; do
+    | tr -s '\\015\\012\\\\' '   '`; do
   gl_ADD_PROG([optional_bin_progs], $gl_i)
 done

--
1.5.6.rc2.17.ge9e7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]