bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: some more tiny string fixes [patches]


From: Jim Meyering
Subject: Re: some more tiny string fixes [patches]
Date: Tue, 12 Aug 2008 21:03:00 +0200

Benno Schulenberg <address@hidden> wrote:
> Attached the promised batch of other string fixes.
>
> The sixth patch removes brackets around the MMDD... part on the
> second synopsis line of 'date'.  They are unneeded, because the
> first synopsis line already desscribes the possibility of having
> zero arguments or only an option argument.  Removing the brackets
> makes it clearer what "or set the system date" refers to.
>
> The equal signs in the eighth patch (to 'dd') are just a suggestion.
> If not acceptable, then at least the "xM M" should move to the end
> of the line; it is rather confusing to find it there out of order.
> Maybe leave it out altogether?

I've left it, as in your patch.
Better to document it, imho.

> In the thirteenth patch (to 'fmt'), maybe replace -DIGITS with
> -WIDTH, as in the Info document?  Or maybe deprecate the option, as
> it is for 'fold'?  Having one accept it and the other not seems odd.

I agree, so changed it to "-WIDTH" in both places.

> Some of these synopsis changes may need to be made to the Info
> documents too, I haven't systematically checked that.

echo's \c correction did indeed need to be fixed in coreutils.texi,
so I amended your change.

Thanks for all of those fixes!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]