[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: use our new timeout program

From: Pádraig Brady
Subject: Re: [PATCH] tests: use our new timeout program
Date: Wed, 1 Oct 2008 22:43:05 +0100
User-agent: Thunderbird (X11/20071008)

Jim Meyering wrote:
> I suspended a 'make check' run, and when I resumed it I was not
> surprised to see this particular test fail.
> Then I kicked myself for not thinking to use coreutils' own
> new timeout program before this.

I presume you mean suspended the machine here, rather than
suspended the job? If just suspending the job, timeout will
still fail as the alarm will keep counting down in the kernel
(and will be sent to timeout when it's running again).

I.E. timeout currently doesn't handle a SIGSTOP or SIGTSTP specially,
as I was thinking it should count down system running time rather
than job running time, as that is dependent on many factors.
Is this correct?

Using timeout is a better solution in any case,
as it will terminate the rm command more quickly.


p.s. don't all posix shells support $((..))
I.E. $(($(date +%s) - start) rather than using $(expr $(date +%s) - $start)
I.E. if we're relying on $() shouldn't we also use $(()) ?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]