[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with

From: Ondřej Vašík
Subject: Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics
Date: Mon, 16 Feb 2009 15:38:38 +0100

Jim Meyering wrote:
> Unfortunately, with this patch, "make check" fails the cp/link-heap test.
> Investigating why, I discovered that it introduces a huge leak into
> cp -a, at least on F10.  80MB worth in this case.
> I'll let you investigate that one ;-)

Leak is in libattr - added by 2.4.43 (~8 months ago) - reported as 
RHBZ #485473 . Kamil Dudka already proposed patch for it. Leak doesn't
occur for older libattr or libattrs with that patch.

> Also, please fold the following into your patch for next time.
> Without the first hunk, with -Werror (via ./configure --enable-gcc-warnings)
> your new code doesn't even compile.

Actually, I dropped new ignore_attr_error() function completely - it
should be safe to pass just NULL instead of &ctx to ignore error
messages. Other mentioned "cosmetic" indentation/ChangeLog format issues
fixed. New version attached.


Attachment: cp-a-selinux-xattrs.patch
Description: Text Data

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy

reply via email to

[Prev in Thread] Current Thread [Next in Thread]