Re: [PATCH] ls: make possible to disable hard links highlighting

[Kamil Dudka]

Hi Pádraig,

thank you for review!

On Tuesday 24 March 2009 02:05:33 Pádraig Brady wrote:
> Kamil Dudka wrote:
> > Hello,
> >
> > promissed patch for ls to disable hard links highlighting is attached.
> > A simple test case is included.
>
> This is better, but dircolors still outputs the hl=44;37 code
> and so this will still be enabled by default.

Should I remove it from dircolors? "make check-ls-dircolors" will then fail. 
Do we have any other ls colors disabled by default?

> This should be disabled by default, and IMHO
> the number of links should be highlighted not the name.

From my point of view it is a significant change to ls.c for no real benefit. 
Do we have any other columns highlighted in ls?

> hardlinked files are common. Consider dirvish snapshots for example,
> or embedded systems with all duplicates hardlinked for space,
> or local git clone, ...

dirvish users can simply disable it if they really want to. If somebody is not 
interested in hard links highlighting it is not enough reason to disable it 
by default. Yes, it is strong reason to make it optionally. That's my 
opinion.


> cheers,
> Pádraig.
>
> p.s. you forgot the '* ' on front of the filenames in the changelog

Good catch. Thanks!


Kamil