bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] df: Fix bug when totaling unknown values.


From: Paul Eggert
Subject: Re: [PATCH] df: Fix bug when totaling unknown values.
Date: Thu, 26 Mar 2009 11:46:21 -0700
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Matthew Woehlke <address@hidden> writes:

> Paul Eggert wrote:
>> +      if (total != UINTMAX_MAX)
>
> Um... I've mentioned that this won't work, haven't I? AIX is (AFAICT)
> giving 0xFFF...FFE, not 0xFFF...FFF.

The later patch (in that same message) adjusted that line to deal with
(uintmax_t) -2.

Maybe some other oddball system in the future will use (uintmax_t) -3?
(I was thinking of having df use (uintmax_t) -100, just to make the code
more future-proof.  :-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]